-
Notifications
You must be signed in to change notification settings - Fork 10k
Document the process.env handling and compat flags #19187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the process.env handling and compat flags #19187
Conversation
src/content/docs/workers/configuration/environment-variables.mdx
Outdated
Show resolved
Hide resolved
vicb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added inline comments.
It would be great to add details to https://developers.cloudflare.com/workers/configuration/secrets/ -> mention the flag and process.env
Thanks
src/content/docs/workers/configuration/environment-variables.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/workers/configuration/environment-variables.mdx
Outdated
Show resolved
Hide resolved
e4e19ef to
9220bba
Compare
src/content/docs/workers/configuration/environment-variables.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/workers/configuration/environment-variables.mdx
Outdated
Show resolved
Hide resolved
vicb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be awesome is to document disallow_importable_env as well.
That is:
- Create a file in
src/content/compatibility-flags/ - Link the flag where it is referenced in the content.
Thanks for documenting this 🎉
|
I will add |
4eb6c56 to
c2f757e
Compare
Refs: cloudflare/workerd#3311
Summary
Screenshots (optional)
Documentation checklist